mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 67863: Updated Mesos implementation to process `CREATE_DISK` & `DESTROY_DISK`.
Date Fri, 13 Jul 2018 12:52:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67863/#review206047
-----------------------------------------------------------


Fix it, then Ship it!





src/master/validation.cpp
Line 2529 (original), 2529 (patched)
<https://reviews.apache.org/r/67863/#comment289008>

    s/target/source/
    
    Here and below.



src/resource_provider/storage/provider.cpp
Line 2759 (original), 2757 (patched)
<https://reviews.apache.org/r/67863/#comment289009>

    Not yours, but s/returns/return/.



src/resource_provider/storage/provider.cpp
Line 3249 (original), 3223 (patched)
<https://reviews.apache.org/r/67863/#comment289010>

    Shouldn't this case result in a `Failure`?


- Jan Schlicht


On July 12, 2018, 6:55 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67863/
> -----------------------------------------------------------
> 
> (Updated July 12, 2018, 6:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9066
>     https://issues.apache.org/jira/browse/MESOS-9066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removes the code for `CREATE_VOLUME`, `DESTROY_VOLUME`,
> `CREATE_BLOCK` and `DESTROY_BLOCK` to adapt the new `CREATE_DISK` and
> `DESTROY_DISK` operations.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 82ba141fca86f5926dc519060c35308026c6048f 
>   src/common/resources_utils.cpp eb7299583c197dd0e44c1c63417206b5c59ab853 
>   src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
>   src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5 
>   src/master/validation.hpp 1ba6d6530d916b5c06762ee2b0bc91b819cd10e5 
>   src/master/validation.cpp 79c67c3c409f03e94f1b5956fd035cd388ab0c3b 
>   src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb

> 
> 
> Diff: https://reviews.apache.org/r/67863/diff/2/
> 
> 
> Testing
> -------
> 
> make
> 
> Tests done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message