mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 67903: Fixed breadcrumb links in site templates.
Date Fri, 13 Jul 2018 07:22:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67903/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Dave Lester, and Till Toenshoff.


Repository: mesos


Description
-------

This patch makes sure that we do not leak newlines into breadcrumb
links created from page titles, and fixes the handling of spaces which
are represented with dashes.


Diffs
-----

  site/source/layouts/basic.erb fc59f00684b61c551f2705b77b3d66a017e1e76e 


Diff: https://reviews.apache.org/r/67903/diff/1/


Testing
-------

Verified that the breadcrumb _Getting Started_ (explicit `breadcrumb` in yaml) and the _Documentation
breadcrumb_ (reachable from any documentation page, e.g., http://mesos.apache.org/documentation/latest/committing/)
have a valid link in the source without newline (some browsers seem to automagically clean
up the broken link).


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message