mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67890: Updated metrics add / remove to avoid double lookups.
Date Thu, 12 Jul 2018 22:32:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67890/#review206030
-----------------------------------------------------------



Looks like this needs a rebase - it must be close enough to `snapshot()` that my recently-merged
patch caused a conflict.

- Greg Mann


On July 11, 2018, 10:53 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67890/
> -----------------------------------------------------------
> 
> (Updated July 11, 2018, 10:53 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When adding / removing metrics, we were performing double lookups
> on the metrics map. Removing these provides a slight performance
> improvement.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 4883c9acaa0cc568e27944661a8208f7b2a356a1

> 
> 
> Diff: https://reviews.apache.org/r/67890/diff/1/
> 
> 
> Testing
> -------
> 
> Before:
> ```
> Added 100000 counters in 2.455274623secs
> Snapshot of 100000 counters in 809.816666ms
> HTTP /snapshot of 100000 counters in 1.739941138secs
> Removed 100000 counters in 3.31390385secs
> ```
> 
> After:
> ```
> Added 100000 counters in 1.954696011secs
> Snapshot of 100000 counters in 826.540283ms
> HTTP /snapshot of 100000 counters in 1.775644115secs
> Removed 100000 counters in 2.404567921secs
> ```
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message