mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67870: Avoided implicit construction of a hashmap in the metrics.
Date Thu, 12 Jul 2018 18:17:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/
-----------------------------------------------------------

(Updated July 12, 2018, 6:17 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Summary (updated)
-----------------

Avoided implicit construction of a hashmap in the metrics.


Repository: mesos


Description (updated)
-------

The master and agent metrics code was passing a `std::map` into a
continuation which accepted its parameter as a `hashmap`, leading
to the implicit construction of an extra object.


Diffs (updated)
-----

  src/master/http.cpp be95d262676af8b2b2d5ea7f7aaef2acee60e748 
  src/slave/http.cpp acbcf7ab9810e1f78639858fa086c2a5183e908f 


Diff: https://reviews.apache.org/r/67870/diff/3/

Changes: https://reviews.apache.org/r/67870/diff/2-3/


Testing
-------


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message