mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 67868: Apply the `override` keyword to Mesos.
Date Thu, 12 Jul 2018 05:13:07 GMT


> On July 10, 2018, 8:02 a.m., Benjamin Bannier wrote:
> > This change seems a number of possible edits, I see e.g., the ones behind `JAVA`
guards untouched. Could you edit these missing configurations as well and mentioned the ones
you modified in the commit message or _Testing done_ section?

I used a number of different build setting. The cmake build seems to be missing some configurations
(e.g. there's no ENABLE_PYTHON, and ENABLE_LIBEVENT doesn't build on F28), but I got most
of the cases.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/#review205900
-----------------------------------------------------------


On July 12, 2018, 5:03 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67868/
> -----------------------------------------------------------
> 
> (Updated July 12, 2018, 5:03 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, Mesos Reviewbot,
Till Toenshoff, and Zhitao Li.
> 
> 
> Bugs: MESOS-9065
>     https://issues.apache.org/jira/browse/MESOS-9065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Apply the `override` keyword to Mesos.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
>   include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
>   include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
>   include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
>   include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
>   include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
>   include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
>   include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
>   include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
>   include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
>   include/mesos/zookeeper/watcher.hpp b2961a54eae74c5810df5d085a39652991685930 
>   src/authentication/cram_md5/authenticatee.hpp d77b2108c83951f0495b67f6494fb7410592e848

>   src/authentication/cram_md5/authenticatee.cpp d43dedf1ec86d3f25811718101ff273a7c0d7333

>   src/authentication/cram_md5/authenticator.hpp a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc

>   src/authentication/cram_md5/authenticator.cpp 0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d

>   src/authorizer/local/authorizer.hpp 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
>   src/authorizer/local/authorizer.cpp 056b1723f5ec34271f1afe3ad810bc498db8f28e 
>   src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
>   src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
>   src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
>   src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
>   src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
>   src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
>   src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
>   src/examples/disk_full_framework.cpp dfbdddae7f50d314e67db59300e5140b0476f807 
>   src/examples/docker_no_executor_framework.cpp 0cbda07872fcf7db091c17ef49f5bcea6d80e660

>   src/examples/dynamic_reservation_framework.cpp e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f

>   src/examples/example_module_impl.cpp b84ff73ba96999072a03461f46717c2f104ae9ff 
>   src/examples/load_generator_framework.cpp 3ae25b221185ec6bd4bd84c478be9a511d763162

>   src/examples/long_lived_executor.cpp 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
>   src/examples/long_lived_framework.cpp 0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
>   src/examples/no_executor_framework.cpp dc75d7802e43164293c5d68ae78eb7fba6deba64 
>   src/examples/persistent_volume_framework.cpp 43375503f1bdb74fba7994f73beb5b5486026e73

>   src/examples/test_anonymous_module.cpp c41b7fc6d5feb7760603df1cda8cc0697a815324 
>   src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
>   src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c 
>   src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
>   src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
>   src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
>   src/examples/test_http_executor.cpp fb9209f630c9c0fa6c1e866eeaf178c560372edc 
>   src/examples/test_http_framework.cpp 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
>   src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
>   src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
>   src/executor/v0_v1executor.hpp ef9bae6ab75279814a5ba9081aa663107195d8e6 
>   src/executor/v0_v1executor.cpp 086cfc74c820657cb3dd7d531f2de44a97832782 
>   src/files/files.cpp 4b8713a2783ec4c4205af071b6cfff3397ec4c1d 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 39dba40bf94df27a870296810712999009b50506

>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 1f9572c00e1285c5a13f3c2e59c058aab6794ebe

>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1deeb08337de7cf367c93b8143a035186c06f2bd

>   src/launcher/default_executor.cpp a70ba062ac14c851e8e276975b46ba4cc0868243 
>   src/launcher/executor.cpp 9fb43c0b741c64f7ad9f3e35b4d81aa627e693dd 
>   src/linux/cgroups.cpp b12e63c112a7aa7a6f7150359ff5409f8214067e 
>   src/linux/perf.cpp f5ac21df3c2dbaeac0b72444d6e6ef4b3bfe78ca 
>   src/log/catchup.cpp ed2e79bff50927e1f5849e8e62662526cac5df1a 
>   src/log/consensus.cpp 76ed3e8e8061ea4ca52fe7cae38cbd81b02d5b3d 
>   src/log/coordinator.cpp 01d2179f88abf0988192fe1a46640c9e8a0605b4 
>   src/log/leveldb.hpp ce93fdc6160fd1947178546660db7ea3c4a1aa1f 
>   src/log/leveldb.cpp 50d7fe576463e017cffd362d649f795261496dda 
>   src/log/log.hpp 7cba0b1c8c84e4f7c1c592da94b74486e68a97e1 
>   src/log/network.hpp 317ae14f754329b2e6e8521f5488107deb2d2c81 
>   src/log/recover.cpp 2167d41098b3bd0fa22807ea9f5616ff79de6d9c 
>   src/log/replica.cpp bb5aa8c7b4df6b6e4f5422a5cbc49d5f7b7d6878 
>   src/log/tool/benchmark.hpp b58a6598f630fc2b26f776bb2eebae04d719d672 
>   src/log/tool/initialize.hpp 8d4fab1a07b347be040689ff538e97c54bdcebea 
>   src/log/tool/read.hpp 00b8617ef015494375db071fd4e3bc31017a2e62 
>   src/log/tool/replica.hpp 456ad1219d9556c7918341b23aa9071faa46e5b5 
>   src/master/allocator/mesos/allocator.hpp 900c8ee405da6e44532dee598edaa42373ebd4e5 
>   src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26

>   src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b

>   src/master/allocator/sorter/drf/sorter.hpp 8a2685433d03fb0f19c832e6e246bba6d09619c3

>   src/master/allocator/sorter/random/sorter.hpp 6e22cf66071240a030b36e80acf31b2111551a96

>   src/master/contender/standalone.hpp 7f68d27f4a4a70a915b660521d10cac60431bbf8 
>   src/master/contender/zookeeper.hpp d280222d5115ead2a7534c938ccfe5311c61d6c8 
>   src/master/contender/zookeeper.cpp 9a0601af09c08a2998b73dee21186b324b656166 
>   src/master/detector/standalone.hpp bbe3ce9b05fa3c321988e25a305507e22b938e4c 
>   src/master/detector/standalone.cpp 2b7c35c33777f0b01978fdf0a9875eda669bca24 
>   src/master/detector/zookeeper.hpp 5d0435ee3863e43a999a90595eaa006bbdfdc449 
>   src/master/detector/zookeeper.cpp 09ae47c6c3851c6179963bcf7e4f73fcd77a826a 
>   src/master/maintenance.hpp 7021f91a0c9443b4f1540adb0dab5faa7950dbde 
>   src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
>   src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5 
>   src/master/quota.hpp 7f43996d9aa3d3f462a6ed750733a55d4ef770c8 
>   src/master/registrar.hpp 70a24fde7cc7ef53540a5559d5bfca3e616c12c0 
>   src/master/registrar.cpp cc1912683cc9a3dee0e84dd085c556b7c90b39bb 
>   src/master/registry_operations.hpp c07268ea0a2dd5c95399d860fcbe8ab804ecef92 
>   src/master/weights.hpp 0ce7a656ce11172ffd93c10e27b2b15588766b3d 
>   src/resource_provider/registrar.hpp 458108af783cb24d2297045cb05eb3b0ef0db7e5 
>   src/resource_provider/storage/disk_profile_adaptor.cpp 7c3aa1614e995889c8587867e8c40483641216d4

>   src/resource_provider/storage/uri_disk_profile_adaptor.hpp 0484933b42d0bd66c689b06cb48f492eef7bc606

>   src/sched/sched.cpp baa6b0c7307b2b72f7b1bc0acafd6e1c34d3029f 
>   src/scheduler/scheduler.cpp 238f86928c609838e5acf077ac4134c2815c98c3 
>   src/secret/resolver.cpp 13d45d056fa3e1a80e9f2d4ed9fbad274d0b0b78 
>   src/slave/container_loggers/lib_logrotate.hpp d0abaa4ba5f545f49d7f04c8b8822cf41c4dbfab

>   src/slave/container_loggers/logrotate.cpp ff0213078e86e13af9e4c886b060103b172c2145

>   src/slave/container_loggers/sandbox.hpp 784b11887a1898e27432f8c8f3fb5d2b9c019b85 
>   src/slave/containerizer/composing.hpp 15b78a952c31ade1c32dd4f01de02cb45403f44a 
>   src/slave/containerizer/composing.cpp 1180eb4c7a852783aa2c4a93fdb8649b0d86b701 
>   src/slave/containerizer/docker.hpp 438d96a417b412a3374f805d658b85515a8450c0 
>   src/slave/containerizer/fetcher_process.hpp 56fecf23761a34a5b1d23fb8770317945381278b

>   src/slave/containerizer/mesos/containerizer.hpp c814d8f67bab365298142b2f4e5c1c1a25303330

>   src/slave/containerizer/mesos/io/switchboard.hpp e52dfe3bb386224418badc40bdd30e4366e0690d

>   src/slave/containerizer/mesos/io/switchboard.cpp 9c6b8a48de22297da754c79571b5e43a7d23c3de

>   src/slave/containerizer/mesos/isolator.hpp d56440c10564d1151bd1d41cd6b14ad41e393d8e

>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 2e9c7e40b05764c53a7b6d73a3b9f31236262c96

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp cde1acec43462d91fe74fd20459a744f29322d36

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5ae825351d865770058162dce8cc616d5e5dc02e

>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 5c63b8f886c604ea587aed7c8469ac4086a06734

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 70f7ed2e1a29398fc338ef80434356af4225360c

>   src/slave/containerizer/mesos/isolators/environment_secret.hpp 376a0a4d7a71df92fd171afb04e7fa81238c2ed3

>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 55102638ff667126af3845f2779bf24b16bade07

>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp b624a60d7ac0feda9c7066413418a3add96108d6

>   src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 414682ba8380e8960ff93666799e2f0f674022c1

>   src/slave/containerizer/mesos/isolators/gpu/isolator.hpp 7b29254c894a7dc658c20b8a7605e02e4c57f769

>   src/slave/containerizer/mesos/isolators/linux/capabilities.hpp 73e26a0c78ccfa43f533d6811f0a58ebe1bc4403

>   src/slave/containerizer/mesos/isolators/linux/devices.hpp 58128f0846dcda0eb80c59adae905fa8b82bc851

>   src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp b3815ae21dd3d31c2c0b94305e262f167fb95030

>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 5ed4a6eceb0a7bd340a85482eab013a157c56cff

>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 197b9d2daf4e0d53d50a997c46e7a6cd906588f5

>   src/slave/containerizer/mesos/isolators/posix.hpp f7dddb26935f95e3a2e1713eff25d07091ce1b92

>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 0e03365218fa13a678f81c7c4391ec21afc4cc11

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp d1e1b32da9fd7059e68fdedcd64e3a772a7f5d2a

>   src/slave/containerizer/mesos/isolators/posix/rlimits.hpp 2d95fb2af0283ed5201cb33b653e6dfb9c35d532

>   src/slave/containerizer/mesos/isolators/volume/host_path.hpp 4540aa325b41fef711572ff57bc8d52321f79112

>   src/slave/containerizer/mesos/isolators/volume/image.hpp 80aa68d8538da396661607f83a829ad09c1a62db

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp 8bf23e096e083b38059988ee2e3b212d36aa6854

>   src/slave/containerizer/mesos/isolators/volume/secret.hpp 2680345c974c5c20bef1f2715677b37f6bead27f

>   src/slave/containerizer/mesos/launch.hpp 00842a5f2b908ff92afe2d07ca7f3f396aec2b0b 
>   src/slave/containerizer/mesos/launcher.hpp c169b875123ca17bfacf485736f57956a6f98be4

>   src/slave/containerizer/mesos/linux_launcher.hpp a542d432e43b902c607c37501d5abe7ad36d841e

>   src/slave/containerizer/mesos/mount.hpp 038426d57e91e0570003b8c313efc3f6bbb0cd47 
>   src/slave/containerizer/mesos/provisioner/appc/store.hpp 37ef7797ba922f7582770ff6a6f5eda9bc81bbc6

>   src/slave/containerizer/mesos/provisioner/appc/store.cpp afe6902ee31142ff56cf1e0fd1afbc78feee359e

>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp 65eb76b1f34a265b2fa7fbe1edac677a0e79646a

>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 54c88d940aa64d13114fc5d79ecbc1d474d169a6

>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 131d75521ca38afae651e8d885ebedad77d86a3e

>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 6bef7b406ed3e3946838a89d352dd714bb9b3d8e

>   src/slave/containerizer/mesos/provisioner/docker/image_tar_puller.hpp f18a758226bd49446ce91355c7fe4f99c28ab21b

>   src/slave/containerizer/mesos/provisioner/docker/image_tar_puller.cpp 6549bf5c2b520148739f4cfe1314cb4f378e147b

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 9abcc3dbd9d56aedfb1a168a6375c2d6e1ff16f1

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 4df679bddd7eead8e067d95b454f9b0a32f77b5d

>   src/slave/containerizer/mesos/provisioner/docker/store.hpp a420fa0cc6bd0bf776c3549131af998133098e64

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 85aad25ac8ecfda125be85fb46d882c3982f3930

>   src/slave/gc_process.hpp 84c83d36a4236d37576f4b38123414e6a4f3e51e 
>   src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
>   src/slave/qos_controllers/noop.hpp 7c07f106148bc34af7a024d94997a2d5e56b4406 
>   src/slave/qos_controllers/noop.cpp b398bd75d053805b4b3afd767b3b5c00ff9073bc 
>   src/slave/resource_estimators/fixed.cpp b43a3acf46391f828a6f86884af70ca26bd5ef18 
>   src/slave/resource_estimators/noop.hpp 6b669ce09d2bf948a483b2c8097663edf8cadd81 
>   src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
>   src/slave/task_status_update_manager.cpp f0cc5023e434fe889b9004a957860490b1bf1e83 
>   src/state/leveldb.cpp 55eab61e07f5732c4bc0d1e04e85b2dfe4586330 
>   src/state/log.cpp 1b2d727d23610d1c953ad0889ef37928d6de8d80 
>   src/state/zookeeper.cpp 7a25e5e697400902d20197de985375f0eb7551d7 
>   src/tests/active_user_test_helper.hpp 0232520304d29425bfb990c24019cbdf68a6c65d 
>   src/tests/agent_container_api_tests.cpp 1dcc256d05b28301aa4cc6c125ae5c04a5f5db59 
>   src/tests/agent_resource_provider_config_api_tests.cpp e1967d1c3a951139e89c6b77001b157276bd1876

>   src/tests/allocator.hpp 73fc06043746a0498d0dd1846fae9433db136d49 
>   src/tests/api_tests.cpp 728fb4c38c17c98b6c2a85447d3f32519c035e56 
>   src/tests/check_tests.cpp 99367df84850633b4cd0f2688bab8d906ab6ec46 
>   src/tests/containerizer.hpp 6acb084671534dd4c12c24a7dca813ed05e6a74b 
>   src/tests/containerizer.cpp b3a09fd2135fd2142ce20093b2fd280f9b0bec97 
>   src/tests/containerizer/capabilities_test_helper.hpp 240bd5f666dc79a2a56953b0535a6c4394dc94d3

>   src/tests/containerizer/cgroups_tests.cpp 7008e7dce7b59b9ba1ee5920daf76c90e4f2c7c4

>   src/tests/containerizer/cni_isolator_tests.cpp b282e1070f6c6d391f0b8f44aa55975f4bbbdfd2

>   src/tests/containerizer/docker_containerizer_tests.cpp e89b8b00eddef09f42f45f122638ebc72b89ab83

>   src/tests/containerizer/docker_tests.cpp 7097efc716ab0e1f34d5a1a35d8e0e173b113c91 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 36fffe2ca7692ed11581e46a5035769db556a793

>   src/tests/containerizer/isolator_tests.cpp bdc3619f18cd65f609d967a036be0467c1e62896

>   src/tests/containerizer/launcher.hpp 40728e0f9f78b7ca32bbcb7485025d2348da3730 
>   src/tests/containerizer/memory_test_helper.hpp 26e295bfd42b12f860c9218ea1d99bdc420172cb

>   src/tests/containerizer/provisioner_appc_tests.cpp 5edd89b60e72f0ded3597b072c3035225f5ef83e

>   src/tests/containerizer/provisioner_backend_tests.cpp e3516fca0e2ce79547d1a56c1fe4ba156abf2c50

>   src/tests/containerizer/provisioner_docker_tests.cpp 0b06eb73b96e73d6ba881db377f9b82d64c7b02a

>   src/tests/containerizer/setns_test_helper.hpp b052497f9a526a6f012449ba8f69ff03930a9c62

>   src/tests/containerizer/volume_image_isolator_tests.cpp c2647f4c2e5e8541dd6f023699f578f575e1d5c1

>   src/tests/containerizer/volume_secret_isolator_tests.cpp 3df575cc8503b35c34b0c5de951d12e1de1c3955

>   src/tests/csi_client_tests.cpp 39dea56e0208c91f549c2f9d2c8f70cef63f2c3c 
>   src/tests/disk_profile_adaptor_tests.cpp 4485f1635f484ce6e1c7c532eedb277f5eee118b 
>   src/tests/environment.hpp 6d9a2bd451c15bb73b8018a6ad5ff04655bbec3b 
>   src/tests/environment.cpp 3b84c0a413193badbbdb6d3ee71d74f3ab85c90b 
>   src/tests/fetcher_cache_tests.cpp f30a30010fa6b04149f8751f4642c3d10a10521b 
>   src/tests/fetcher_tests.cpp 5e6a1c31a75732c7c35acc4dea67b8f91e192322 
>   src/tests/files_tests.cpp 3e749de3160da9d25662f981f6fc7afeee59082a 
>   src/tests/hdfs_tests.cpp 701350ecb3d3b6c183b18fcb5f2a71451ff64393 
>   src/tests/health_check_tests.cpp 34102e2e3ff90c194bea83ae8a702181121d6522 
>   src/tests/hierarchical_allocator_tests.cpp 597469e0e897e10e9805798a4ec3f445c7dc28b0

>   src/tests/hook_tests.cpp 70ffd92ba3f740a6abbbf5e6fd39e27c187b032e 
>   src/tests/http_authentication_tests.cpp f84af7c35520ae2f13c3dc9749e446995b1c6c7f 
>   src/tests/http_server_test_helper.hpp d034ef5ba9561110863cb0c47be4223cbcc05301 
>   src/tests/kill_policy_test_helper.hpp 29651102ec46b477e6e797c6e6bdef5b10afa665 
>   src/tests/log_tests.cpp ac1cca7e5fd812d019bed049e3407adb48662251 
>   src/tests/logging_tests.cpp 1e2d09a05db3d4ea178a96c910531c23b96ad263 
>   src/tests/master_allocator_tests.cpp 824a7554858fb8356751f3469960dddd7505bd98 
>   src/tests/master_maintenance_tests.cpp 2d48d6a674b120c95092bcffa5864ea88eb55ce3 
>   src/tests/master_quota_tests.cpp d836482f5593b462ad235620741148678ac2651d 
>   src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 
>   src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe 
>   src/tests/metrics_tests.cpp f5c6cc9737d499ed3033e0cc1e32ad1142a30c6e 
>   src/tests/mock_docker.hpp f5a08d0e78dd09dd86379bb237d94838f43644d7 
>   src/tests/mock_fetcher.hpp 3825faabfa0bdfbd4a8e8d15548153185409c89d 
>   src/tests/mock_registrar.hpp b070166d1c3b9baa0d1ad992dc4fa783daf0d8f3 
>   src/tests/mock_slave.hpp 2594d6d9f2ed997b3d1d4cf577b9353db87e769b 
>   src/tests/module_tests.cpp a0b6c179607351162fd8b387645d802996d72d51 
>   src/tests/oversubscription_tests.cpp e2bd8d44483348f336924d923ecf79f818fafc5e 
>   src/tests/paths_tests.cpp 3fa8f526e4d14f151a771a8b433d277607e6d3fc 
>   src/tests/persistent_volume_endpoints_tests.cpp ab2680fadefd5af0285c0270fa8cbb50a49f49d7

>   src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c 
>   src/tests/rate_limiting_tests.cpp 802d5ca427ae668bde3bcd35311315d16a0db440 
>   src/tests/registrar_tests.cpp d3e4ee0164b8730b39ab05f4880fd0aa034ec8b0 
>   src/tests/reservation_endpoints_tests.cpp 61af7ac9212b2b42a6a9f6ef8beefc10d3438fd2

>   src/tests/slave_recovery_tests.cpp e8333402d8524a4bf302872d246fe5f5c006bdc5 
>   src/tests/state_tests.cpp 1063866de445f46a5d4ee270b842e60c357dc80d 
>   src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5

>   src/tests/uri_fetcher_tests.cpp 816d8ec2503ea79d069c062dfa2f01224b263bf6 
>   src/tests/zookeeper.hpp e921fd1188a343b1e864f9dcc08cd0169fb3c8a0 
>   src/uri/fetchers/copy.hpp 4d612fe0d22a91594adc58589ca18a06e5b167ba 
>   src/uri/fetchers/curl.hpp e07c1e2aadf4222122e8dae6078f406bf8c52887 
>   src/uri/fetchers/docker.hpp cdbab9a5684a68a729be12bc06d331acca137da5 
>   src/uri/fetchers/hadoop.hpp 46f74c8a2e97f1a0168343d4ed62666158e86638 
>   src/version/version.hpp 1c86924ed5fbfb976877153915d87e8a76758497 
>   src/watcher/whitelist_watcher.hpp 050d5487177db021e68627c919f935fd689b76ee 
>   src/zookeeper/contender.cpp daf1c6e318a1220f268eccafd0e6f70731e46547 
>   src/zookeeper/detector.cpp 71ab101ee4637248c41229b10830a48580d7f2bd 
>   src/zookeeper/zookeeper.cpp 2efc158922e3b9ac37f33054ecb080093323bb82 
> 
> 
> Diff: https://reviews.apache.org/r/67868/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message