mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 67869: Add use of `override` to the Mesos C++ style guide.
Date Thu, 12 Jul 2018 05:03:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67869/
-----------------------------------------------------------

(Updated July 12, 2018, 5:03 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, Mesos Reviewbot,
Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
    https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
-------

Add an explicit guideline to the Mesos C++ style guide that the use of
`override` keyword is required. Update cpplint and clang-tidy tooling
to encourage this.


Diffs (updated)
-----

  docs/c++-style-guide.md 80a1af318984d47bdfa641aa12e28963d3183fea 
  support/clang-tidy fcffb39089573a708dc3f2052f639a1a3621040d 
  support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 


Diff: https://reviews.apache.org/r/67869/diff/2/

Changes: https://reviews.apache.org/r/67869/diff/1-2/


Testing
-------

Manual. The `cpplint` change doesn't appear to enforce the use of `override`.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message