mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 67866: Apply the `override` keyword to stout.
Date Thu, 12 Jul 2018 05:02:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67866/
-----------------------------------------------------------

(Updated July 12, 2018, 5:02 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, Mesos Reviewbot,
Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
    https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
-------

Apply the `override` keyword to stout.


Diffs (updated)
-----

  3rdparty/stout/include/stout/lambda.hpp 252de895ac679715ef20015d8887b1a78f264fe8 
  3rdparty/stout/include/stout/tests/utils.hpp e7336a586cc3ad4147cfe963604059026fc1e3f1 
  3rdparty/stout/tests/main.cpp 144399d86c9177b2ec9a2ae8e95c55d5aa0defd2 
  3rdparty/stout/tests/os/rmdir_tests.cpp 518afc0ddedc4c53d01ac08a36234964f088420d 
  3rdparty/stout/tests/os/sendfile_tests.cpp cc1fa113eae5c2c68e2f4f21c35b700650db787c 
  3rdparty/stout/tests/subcommand_tests.cpp 211d28df1bba069c848000a19d3f6038e71d8159 


Diff: https://reviews.apache.org/r/67866/diff/2/

Changes: https://reviews.apache.org/r/67866/diff/1-2/


Testing
-------

make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message