mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67863: Updated Mesos implementation to process `CREATE_DISK` & `DESTROY_DISK`.
Date Thu, 12 Jul 2018 02:23:05 GMT


> On July 11, 2018, 10:28 a.m., Jan Schlicht wrote:
> > src/master/master.cpp
> > Lines 4642 (patched)
> > <https://reviews.apache.org/r/67863/diff/1/?file=2056879#file2056879line4655>
> >
> >     We should log a warning and break here, not crash. The operation isn't fully
validated at this point. Full validation is done in `_accept`.

Thanks for pointing this out! This is a really stupid and dangerous bug :(


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67863/#review205961
-----------------------------------------------------------


On July 10, 2018, 3:11 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67863/
> -----------------------------------------------------------
> 
> (Updated July 10, 2018, 3:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9066
>     https://issues.apache.org/jira/browse/MESOS-9066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removes the code for `CREATE_VOLUME`, `DESTROY_VOLUME`,
> `CREATE_BLOCK` and `DESTROY_BLOCK` to adapt the new `CREATE_DISK` and
> `DESTROY_DISK` operations.
> 
> Note that in SLRP we made CHECKs against disk types instead of returning
> failures, Since the disk types should have been validated by the master.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 82ba141fca86f5926dc519060c35308026c6048f 
>   src/common/resources_utils.cpp eb7299583c197dd0e44c1c63417206b5c59ab853 
>   src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
>   src/master/master.cpp 0c0d6ca375b806a02625261f7e272a126bc4debe 
>   src/master/validation.hpp 1ba6d6530d916b5c06762ee2b0bc91b819cd10e5 
>   src/master/validation.cpp 79c67c3c409f03e94f1b5956fd035cd388ab0c3b 
>   src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb

> 
> 
> Diff: https://reviews.apache.org/r/67863/diff/1/
> 
> 
> Testing
> -------
> 
> make
> 
> Tests done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message