mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
Date Thu, 12 Jul 2018 00:31:11 GMT


> On July 11, 2018, 2:24 p.m., Jan Schlicht wrote:
> > src/tests/mesos.hpp
> > Lines 1423 (patched)
> > <https://reviews.apache.org/r/67864/diff/2/?file=2058393#file2058393line1423>
> >
> >     This isn't used, why introduce it here?

Just for consistency. I could remove this as well.


> On July 11, 2018, 2:24 p.m., Jan Schlicht wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 1107-1125 (original), 1107-1126 (patched)
> > <https://reviews.apache.org/r/67864/diff/2/?file=2058397#file2058397line1107>
> >
> >     Nit: Why change this from creating a `BLOCK` to creating a `MOUNT`?

I probably used `BLOCK` before just to shorten the test a bit (since we don't need to specify
the target type).
And I made the change here just to use a type that is well supported in Mesos.

But it actually doesn't matter at all lol. The code this test covers is basically the same.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205968
-----------------------------------------------------------


On July 10, 2018, 9:15 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
> 
> (Updated July 10, 2018, 9:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9066
>     https://issues.apache.org/jira/browse/MESOS-9066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c 
>   src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
>   src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 
>   src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd 
>   src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe 
>   src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838

>   src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c 
>   src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6 
>   src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff

>   src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5

> 
> 
> Diff: https://reviews.apache.org/r/67864/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message