mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67870: Fixed an incorrect type in the master's metrics code.
Date Wed, 11 Jul 2018 23:11:03 GMT


> On July 10, 2018, 3:56 p.m., James Peach wrote:
> > Do you think we should make the `hashmap` conversion constructor `explicit` to prevent
future instances of this bug?

Yea that seems like a good idea to me. I'll submit a patch for this.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/#review205913
-----------------------------------------------------------


On July 10, 2018, 6:23 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67870/
> -----------------------------------------------------------
> 
> (Updated July 10, 2018, 6:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed an incorrect type in the master's metrics code.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
> 
> 
> Diff: https://reviews.apache.org/r/67870/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message