mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 67730: Made Git normalize all line endings automatically.
Date Wed, 11 Jul 2018 18:23:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 11, 2018, 11:23 a.m.)

Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.

Repository: mesos


Instead of relying on the user to `core.autocrlf = true` before
cloning, we now set this in `.gitattributes` for all files.

Only one file needed normalization via `git add --renormalize .`, it
was `site/doap.rdf`.

The Windows instructions were updated to remove the note about setting
autocrlf globally, and the outdated note to use Python 2 was updated
while we were in the file.


  .gitattributes PRE-CREATION 
  docs/ 86b9fe31b2036060c6fbfb080fc7981a943759bb 
  site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 


Testing (updated)

This RR is the test since it'll trigger the currently broken review bot.

Also see

I created a new repo, set git config core.autocrlf false, added Mesos as a remote, checked
out, and verified that the build failed with the GNU Patch assertion due to line-endings.
I then applied this patch and did a hard reset, and veriried that the build worked correctly.
So this is good to go, I think. Any objections?


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message