mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67855: Added virtualenv requirements watcher to Python 3 mesos-style.py.
Date Wed, 11 Jul 2018 09:22:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67855/
-----------------------------------------------------------

(Updated July 11, 2018, 9:22 a.m.)


Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.


Changes
-------

Improved commit message.


Bugs: MESOS-8882
    https://issues.apache.org/jira/browse/MESOS-8882


Repository: mesos


Description (updated)
-------

The Python and JavaScript linters run by mesos-style.py, called
by our Git hooks, require a virtual environment. This virtual
environment needs to be rebuilt by running `build-virtualenv`
each time the pip dependencies of our Python codebase are
updated.

The check `should_build_virtualenv` had not been added to the Python 3
`mesos-style.py` for an unknown reason and this is now fixed.

We pass the Python interpreter used to run `mesos-style.py` when running
`build-virtualenv` in case Python 3 is used to run `mesos-style.py`
but Python 2 is still the default `python`.


Diffs (updated)
-----

  support/python3/mesos-style.py 0a4b1b1a0287011faf4488522f88587e07b3c874 


Diff: https://reviews.apache.org/r/67855/diff/2/

Changes: https://reviews.apache.org/r/67855/diff/1-2/


Testing
-------

Checked that this commit trigerred the script (I am using Python 3 by default).


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message