mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <>
Subject Re: Review Request 67855: Added virtualenv requirements watcher to Python 3
Date Wed, 11 Jul 2018 09:22:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 11, 2018, 9:22 a.m.)

Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.


Improved commit message.

Bugs: MESOS-8882

Repository: mesos

Description (updated)

The Python and JavaScript linters run by, called
by our Git hooks, require a virtual environment. This virtual
environment needs to be rebuilt by running `build-virtualenv`
each time the pip dependencies of our Python codebase are

The check `should_build_virtualenv` had not been added to the Python 3
`` for an unknown reason and this is now fixed.

We pass the Python interpreter used to run `` when running
`build-virtualenv` in case Python 3 is used to run ``
but Python 2 is still the default `python`.

Diffs (updated)

  support/python3/ 0a4b1b1a0287011faf4488522f88587e07b3c874 




Checked that this commit trigerred the script (I am using Python 3 by default).


Armand Grillet

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message