mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 67881: Fixed the error log in POSIX `os::rmdir`.
Date Tue, 10 Jul 2018 23:14:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67881/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Meng Zhu.


Repository: mesos


Description
-------

The POSIX implementation of `os::rmdir` uses FTS functions to walk
through all paths under a given directory. According to the manpage,
the `fts_path` field "contains the path specified to fts_open() as a
prefix," so should not be joined with the given directory again. See:
http://man7.org/linux/man-pages/man3/fts.3.html


Diffs
-----

  3rdparty/stout/include/stout/os/posix/rmdir.hpp 947bb243ca3ad070497369f8108064d9f4c58b30



Diff: https://reviews.apache.org/r/67881/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message