mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.
Date Tue, 10 Jul 2018 20:26:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67663/
-----------------------------------------------------------

(Updated July 10, 2018, 8:26 p.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-8825
    https://issues.apache.org/jira/browse/MESOS-8825


Repository: mesos


Description
-------

Now the `UriDiskProfileAdaptor` module can handle disappeared profiles
when polling the profile matrix, and performs a best-effort immutability
check for reappeared profiles.


Diffs (updated)
-----

  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 0484933b42d0bd66c689b06cb48f492eef7bc606

  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7

  src/tests/disk_profile_adaptor_tests.cpp 4485f1635f484ce6e1c7c532eedb277f5eee118b 


Diff: https://reviews.apache.org/r/67663/diff/3/

Changes: https://reviews.apache.org/r/67663/diff/2-3/


Testing
-------

sudo make check

A end-to-end test will be added later in the chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message