mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67856: Updated Python virtual environment dependencies.
Date Tue, 10 Jul 2018 16:36:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67856/#review205917
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On July 9, 2018, 12:38 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67856/
> -----------------------------------------------------------
> 
> (Updated July 9, 2018, 12:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-8882
>     https://issues.apache.org/jira/browse/MESOS-8882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixes the error message when running support/build-virtualenv:
> `npm WARN ajv-keywords@3.2.0 requires a peer of ajv@^6.0.0 but none
> is installed. You must install peer dependencies yourself.`.
> 
> Updates the PyInstaller dependency due to issues with PyInstaller
> 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/pip-requirements.txt aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 
>   support/pip-requirements.txt 5877ad283d3b2cbb5fc46cf712ebaf7a6bccc66d 
> 
> 
> Diff: https://reviews.apache.org/r/67856/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `support/build-virtualenv` successfully.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message