mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.
Date Tue, 10 Jul 2018 16:02:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67663/#review205914
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/resource_provider/storage/uri_disk_profile_adaptor.cpp
Line 248 (original), 244 (patched)
<https://reviews.apache.org/r/67663/#comment288843>

    `foreachpair` would give us a way to give better names to `first` and `second`.



src/resource_provider/storage/uri_disk_profile_adaptor.cpp
Line 292 (original), 281 (patched)
<https://reviews.apache.org/r/67663/#comment288840>

    Use `contains` here.



src/resource_provider/storage/uri_disk_profile_adaptor.cpp
Lines 284 (patched)
<https://reviews.apache.org/r/67663/#comment288844>

    Is this something actionable to warn about or in reality just `INFO`?



src/resource_provider/storage/uri_disk_profile_adaptor.cpp
Lines 291 (patched)
<https://reviews.apache.org/r/67663/#comment288842>

    `foreachpair` would give us a way to give better names to `first` and `second`.



src/resource_provider/storage/uri_disk_profile_adaptor.cpp
Line 303 (original), 303 (patched)
<https://reviews.apache.org/r/67663/#comment288841>

    We have already updated the profiles and can log `profileMatrix.size()` here.


- Benjamin Bannier


On June 21, 2018, 6:27 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67663/
> -----------------------------------------------------------
> 
> (Updated June 21, 2018, 6:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8825
>     https://issues.apache.org/jira/browse/MESOS-8825
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now the `UriDiskProfileAdaptor` module can handle disappeared profiles
> when polling the profile matrix, and performs a best-effort immutability
> check for reappeared profiles.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.hpp 0484933b42d0bd66c689b06cb48f492eef7bc606

>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7

>   src/tests/disk_profile_adaptor_tests.cpp 4485f1635f484ce6e1c7c532eedb277f5eee118b 
> 
> 
> Diff: https://reviews.apache.org/r/67663/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> A end-to-end test will be added later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message