mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67866: Apply the `override` keyword to stout.
Date Tue, 10 Jul 2018 08:02:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67866/#review205898
-----------------------------------------------------------



Running clang-tidy on this produced more changes for me

    3rdparty/stout/tests/main.cpp                      |  2 +-
    3rdparty/stout/tests/os/rmdir_tests.cpp            |  2 +-
    3rdparty/stout/tests/os/sendfile_tests.cpp         |  2 +-
    3rdparty/stout/tests/subcommand_tests.cpp          |  4 +--
    
When doing automated `clang-tidy` refactors it is also always very useful to call out how
the compilation database was generated (e.g., what flags were used). Could you add that to
either the commit message or the _Testing done_ section?

- Benjamin Bannier


On July 10, 2018, 5:30 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67866/
> -----------------------------------------------------------
> 
> (Updated July 10, 2018, 5:30 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, Mesos Reviewbot,
Till Toenshoff, and Zhitao Li.
> 
> 
> Bugs: MESOS-9065
>     https://issues.apache.org/jira/browse/MESOS-9065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Apply the `override` keyword to stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/lambda.hpp 252de895ac679715ef20015d8887b1a78f264fe8 
>   3rdparty/stout/include/stout/tests/utils.hpp e7336a586cc3ad4147cfe963604059026fc1e3f1

> 
> 
> Diff: https://reviews.apache.org/r/67866/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message