mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67847: Fixed installation of storage disk profile adaptor header.
Date Mon, 09 Jul 2018 20:15:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67847/#review205869
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On July 6, 2018, 8:50 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67847/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 8:50 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Automake does not care about the source directory of headers it
> installs, but instead either installs into `$(pkgincludedir)` or some
> `COMPONENTdir`. When doing in-tree builds on the other hand the
> header source directories matter since the build is performed against
> a source tree, not an installed tree.
> 
> This patch fixes installation of the `disk_profile_adaptor.hpp` header
> which while it resided in the source directory
> `mesos/resource_provider/storage` was installed into
> `mesos/resource_provider`. This made e.g., other headers relying on
> the disk profile adaptor header unusable when building against
> installed Mesos headers. We now make sure to install to the `storage/`
> subdirectory.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
> 
> 
> Diff: https://reviews.apache.org/r/67847/diff/1/
> 
> 
> Testing
> -------
> 
> `make distcheck`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message