mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67814: Added per-framework metrics for offer operations.
Date Mon, 09 Jul 2018 18:07:33 GMT


> On July 6, 2018, 9:48 p.m., Gastón Kleiman wrote:
> > src/master/master.cpp
> > Lines 4738-4740 (patched)
> > <https://reviews.apache.org/r/67814/diff/1/?file=2049305#file2049305line4738>
> >
> >     As discussed offline, it would be better to increment these counters after having
validated the operations. That means that we would probably have to call `FrameworkMetrics::incrementOperation`
in each `case` statement.
> >     
> >     We shoud also add an `invalidOperations` counter and increase it accordingly.

Sounds good. I created a ticket to add invalid/unauthorized operation counters here: https://issues.apache.org/jira/browse/MESOS-9059


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67814/#review205825
-----------------------------------------------------------


On July 9, 2018, 6:03 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67814/
> -----------------------------------------------------------
> 
> (Updated July 9, 2018, 6:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert
Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-8845
>     https://issues.apache.org/jira/browse/MESOS-8845
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework metrics for offer operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67814/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message