mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67669: Allow resources to be removed when updating the sorter.
Date Fri, 06 Jul 2018 23:28:25 GMT


> On June 20, 2018, 2:20 p.m., Benjamin Bannier wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 921 (original)
> > <https://reviews.apache.org/r/67669/diff/1/?file=2042688#file2042688line924>
> >
> >     While this might not be required by the allocator, generally an operation changing
the resource quantity is not supported by the `Sorter` interface.
> >     
> >     We already rely on the invariant being checked here in above calls to `Sorter::update`
which explicit disallow such updates. In order to support operations changing the quantity
of the stripped resources we need to do additional work.
> 
> Chun-Hung Hsiao wrote:
>     I added a unit test and updated the description of `Sorter::update`, but I'm hesitating
to add some more concrete checks. We discussed about checking the resources names don't change,
but changing names are essentially removing the old name and adding a new one, so it seems
not consistent to have such checks.
>     
>     Another concern I have is that we now rely on the caller to update the allocation
and the total resources synchronously, but I cannot find a good way to validate that. Suggestions?

After discussed with BenM, I'm keeping the check, but just relax it to support what we need.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/#review205079
-----------------------------------------------------------


On July 6, 2018, 11:27 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67669/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 11:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng Zhu.
> 
> 
> Bugs: MESOS-8995
>     https://issues.apache.org/jira/browse/MESOS-8995
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch allows the allocator to remove resources when calling
> `Sorter::update`, so Mesos can remove resources that are no longer
> available through resource conversions.
> 
> An example usage is that we can make `DESTROY_VOLUME` to convert a
> volume with a stale profile to an empty resource, so the disk space
> will disappear instead of being offered out to other frameworks.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG d0cc0e0a4d2a7aa69cadc21923c7af397ebcbb25 
>   docs/upgrades.md cc8a251945af27a432dbeb5585b998cd84e35b22 
>   src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b

>   src/master/allocator/sorter/drf/sorter.cpp 755a36ead42a91053c881fc46dc6acb39c819cac

>   src/master/allocator/sorter/sorter.hpp e5e86513dc4023d9c471753897635923c6c9203f 
>   src/tests/sorter_tests.cpp 266a9e72597b3aadc9756f61736c0adf0b1a5831 
> 
> 
> Diff: https://reviews.apache.org/r/67669/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message