mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 67669: Allow resources to be removed when updating the sorter.
Date Fri, 06 Jul 2018 23:27:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 6, 2018, 11:27 p.m.)

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng Zhu.


Keep the check but only relex it to support MESOS-8825.

Summary (updated)

Allow resources to be removed when updating the sorter.

Bugs: MESOS-8995

Repository: mesos

Description (updated)

This patch allows the allocator to remove resources when calling
`Sorter::update`, so Mesos can remove resources that are no longer
available through resource conversions.

An example usage is that we can make `DESTROY_VOLUME` to convert a
volume with a stale profile to an empty resource, so the disk space
will disappear instead of being offered out to other frameworks.

Diffs (updated)

  CHANGELOG d0cc0e0a4d2a7aa69cadc21923c7af397ebcbb25 
  docs/ cc8a251945af27a432dbeb5585b998cd84e35b22 
  src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/sorter/drf/sorter.cpp 755a36ead42a91053c881fc46dc6acb39c819cac 
  src/master/allocator/sorter/sorter.hpp e5e86513dc4023d9c471753897635923c6c9203f 
  src/tests/sorter_tests.cpp 266a9e72597b3aadc9756f61736c0adf0b1a5831 




sudo make check


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message