mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`.
Date Fri, 06 Jul 2018 23:25:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67664/
-----------------------------------------------------------

(Updated July 6, 2018, 11:25 p.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Jan's comment.


Bugs: MESOS-9010
    https://issues.apache.org/jira/browse/MESOS-9010


Repository: mesos


Description
-------

Since a resource provider and its operation status update manager run in
different actors, the `UPDATE_OPERATION_STATUS` call of a completed
operation may race with an `UPDATE_STATE` call.

To deal with this race, the agent should update the latest statuses of
all completed operations received in the `UPDATE_STATE` call to avoid
erroneously applying those operations when receiving
`UPDATE_OPERATION_STATUS`es.


Diffs (updated)
-----

  src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 
  src/slave/slave.cpp 06c2f5ffb6ac79b746c1db4a6762b9dc7e88c471 
  src/tests/slave_tests.cpp b46fb8efc524852f62428040ff958bd44e9efe9f 


Diff: https://reviews.apache.org/r/67664/diff/3/

Changes: https://reviews.apache.org/r/67664/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message