mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67812: Added per-framework offer metrics.
Date Fri, 06 Jul 2018 21:01:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/#review205824
-----------------------------------------------------------




src/master/master.cpp
Lines 4160 (patched)
<https://reviews.apache.org/r/67812/#comment288730>

    I think it would be nicer not to increment the counter in the loop, but to use a variable
to count the number of accepted offers and then to increment the counter once right after
closing this loop.



src/master/master.cpp
Lines 6012 (patched)
<https://reviews.apache.org/r/67812/#comment288731>

    Ditto incrementing the counter only one after the loop.


- Gastón Kleiman


On July 6, 2018, 1:52 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67812/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 1:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert
Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-8848
>     https://issues.apache.org/jira/browse/MESOS-8848
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework offer metrics.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67812/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message