mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67809: Added per-framework metrics for scheduler events.
Date Fri, 06 Jul 2018 20:46:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/#review205823
-----------------------------------------------------------


Fix it, then Ship it!





src/master/metrics.hpp
Lines 238 (patched)
<https://reviews.apache.org/r/67809/#comment288728>

    Let's name this `update_event_task_states`.



src/master/metrics.cpp
Lines 678 (patched)
<https://reviews.apache.org/r/67809/#comment288729>

    Let's add a CHECK here like the one in #672.


- Gastón Kleiman


On July 6, 2018, 11:01 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67809/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 11:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert
Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-8844
>     https://issues.apache.org/jira/browse/MESOS-8844
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework metrics for scheduler events.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67809/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message