mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Date Fri, 06 Jul 2018 19:37:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/
-----------------------------------------------------------

(Updated July 6, 2018, 9:37 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Addressed comments from Chun.


Bugs: MESOS-8473
    https://issues.apache.org/jira/browse/MESOS-8473


Repository: mesos


Description
-------

This patch adds filtering of operations reported for `GET_OPERATIONS`
calls. A principal is allowed to view see all operations for which it
is allowed to see the role of the underlying resources.


Diffs (updated)
-----

  src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
  src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c 
  src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 


Diff: https://reviews.apache.org/r/67693/diff/4/

Changes: https://reviews.apache.org/r/67693/diff/3-4/


Testing
-------

`make check`

The added tests fails without the corresponding changes to the master and agent code.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message