mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67722: Fixed unproperly guarded future.
Date Fri, 06 Jul 2018 14:07:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/#review205800
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67722']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722/logs/mesos-tests-stdout.log):

```
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (601 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[       OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1324 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[       OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (798 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (802 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1009 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[       OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (601 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[       OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5064 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4957 ms)
[----------] 24 tests from DockerContainerizerTest (92181 ms total)

[----------] 1 test from HungDockerTest
[ RUN      ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address
is @0000009B422FBBE0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this
mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted
but never is. Its address is @0000009B422FBE40.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull)
should be deleted but never is. Its address is @000001A7152A3780.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address
is @000001A715B247F0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never
is. Its address is @000001A715C42C68.
ERROR: 5 leaked mock objects found at program exit.
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722/logs/mesos-tests-stderr.log):

```
I0706 14:06:51.745223 16392 authenticatee.cpp:299] Authentication success
I0706 14:06:51.745223 10128 master.cpp:9795] Successfully authenticated principal 'test-principal'
at scheduler-03f4ddad-9b51-4d58-8f7d-39fbd0b50851@192.10.1.6:57933
I0706 14:06:51.746255 11292 sched.cpp:501] Successfully authenticated with master master@192.10.1.6:57933
I0706 14:06:51.747315 14768 master.cpp:2927] Received SUBSCRIBE call for framework 'default'
at scheduler-03f4ddad-9b51-4d58-8f7d-39fbd0b50851@192.10.1.6:57933
I0706 14:06:51.748229 14768 master.cpp:2234] Authorizing framework principal 'test-principal'
to receive offers for roles '{ * }'
I0706 14:06:51.748229 11692 master.cpp:3008] Subscribing framework default with checkpointing
disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0706 14:06:51.749234 11692 master.cpp:9994] Adding framework be640f53-010a-4474-a4d1-c7a79a763693-0000
(default) at scheduler-03f4ddad-9b51-4d58-8f7d-39fbd0b50851@192.10.1.6:57933 with roles {
 } suppressed
I0706 14:06:51.750233 12128 sched.cpp:749] Framework registered with be640f53-010a-4474-a4d1-c7a79a763693-0000
I0706 14:06:51.750233 10128 hierarchical.cpp:299] Added framework be640f53-010a-4474-a4d1-c7a79a763693-0000
E0706 14:06:51.833406 11292 slave.cpp:7289] EXIT with status 1: Failed to perform recovery:
Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat
-H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not
recognized as an internal or external command,

operable program or batch file.

'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.

To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\6PGQZj\meta\slaves\latest
This ensures that the agent does not recover old live executors.

If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)

Finally, restart the agent.
```

- Mesos Reviewbot Windows


On July 6, 2018, 1:06 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67722/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 1:06 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes a bug where the code path could cause a crash because
> of calling `Fture<T>::get()` on a future which is failed.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67722/diff/3/
> 
> 
> Testing
> -------
> 
> ```sh
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message