mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.
Date Thu, 05 Jul 2018 21:35:51 GMT


> On July 5, 2018, 1:33 p.m., Benjamin Mahler wrote:
> > Also, is there a ticket? Did any releases ship with this broken? i.e. Do we need
to backport this?

No, should I create one? AFAIK the commit mentioned in the description was not included in
any existing release. I checked branches `1.5.x` and `1.6.x` and didn't find it there.


- Ilya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/#review205760
-----------------------------------------------------------


On July 5, 2018, 2:31 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67820/
> -----------------------------------------------------------
> 
> (Updated July 5, 2018, 2:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Commit a52e5288ea94ec7d84f82c6c01c1ce3c7a3902db replaced std::list with
> std::vector in several places including the Isolator interface. However
> XfsDiskIsolatorProcess, PortMappingIsolatorProcess and
> NetworkPortsIsolatorProcess were not updated and because of that their
> recover() method became "disabled".
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 6ff3820de6af544c6ec92b0e76fd934715b87a96

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 3f51542ca27217c1063c19be481e8c47481f1e0c

>   src/slave/containerizer/mesos/isolators/network/ports.hpp 8d467ceceae21d30318195785dce635d054d0f8d

>   src/slave/containerizer/mesos/isolators/network/ports.cpp 82c14413cef0ac14ccfbc700f8f10a6c120c7fb0

>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b

>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9

> 
> 
> Diff: https://reviews.apache.org/r/67820/diff/2/
> 
> 
> Testing
> -------
> 
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery`
test, that was broken because of the issue, passed.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message