mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 67825: Added a resources utility `hasShared()`.
Date Thu, 05 Jul 2018 21:35:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67825/#review205768
-----------------------------------------------------------




include/mesos/resources.hpp
Lines 448-449 (patched)
<https://reviews.apache.org/r/67825/#comment288660>

    This implies adding a lot of other has functions:
    
    hasUnreserved
    hasPersistentVolumes
    hasRevocable
    hasNonRevocable
    hasNonShared
    etc
    
    Can we just use `shared().empty()` in place of adding this for now?


- Benjamin Mahler


On July 4, 2018, 12:57 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67825/
> -----------------------------------------------------------
> 
> (Updated July 4, 2018, 12:57 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 175833c7d08443955d0aacd844c7df180d43e829 
>   include/mesos/v1/resources.hpp b607b68fd905c09356288e8bc16081a7fe15e6ba 
>   src/common/resources.cpp 253b8bcd720e38f485b5cd2f5b7666ac85e67d38 
>   src/v1/resources.cpp ab8fc3e738038b9b34d4902aed9f15a59b416217 
> 
> 
> Diff: https://reviews.apache.org/r/67825/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message