mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.
Date Tue, 03 Jul 2018 23:57:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/
-----------------------------------------------------------

(Updated July 3, 2018, 4:57 p.m.)


Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.


Changes
-------

Fixed flaky test.


Bugs: MESOS-8987
    https://issues.apache.org/jira/browse/MESOS-8987


Repository: mesos


Description
-------

The Mesos master sends a `ShutdownMessage` to an agent if there is an
authentication or an authorization error during agent (re)registration.

Upon receipt of this message, the agent kills alls its tasks and commits
suicide. This means that transient auth errors can lead to whole agents
being killed along with it's tasks.

This patch prevents the master from sending a `ShutdownMessage` in these
cases.


Diffs (updated)
-----

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
  src/tests/master_authorization_tests.cpp 80b9d49ba334b915461ff5d6df6c9f922d7593e3 


Diff: https://reviews.apache.org/r/67791/diff/3/

Changes: https://reviews.apache.org/r/67791/diff/2-3/


Testing
-------

`bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message