-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67822/#review205696
-----------------------------------------------------------
Fix it, then Ship it!
Could you change the ticket to MESOS-9049?
src/slave/gc.cpp
Line 256 (original), 256 (patched)
<https://reviews.apache.org/r/67822/#comment288590>
Do you think the following will improve the readability?
```
if (unmount.isError()) {
...
// Find the next garbage collected path containing this mount point.
continue;
} else {
break;
}
```
Please feel free to drop this if you think this is not necessary.
- Chun-Hung Hsiao
On July 3, 2018, 10:08 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67822/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 10:08 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-9049
> https://issues.apache.org/jira/browse/MESOS-9049
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We could potentially schedule the framework dir, executor dir, and
> executor run sandbox to gc at the same time, and then these
> paths will be gc independently, although they are parents and
> children directories. This patch makes sure we do not call unmount
> anymore after a success.
>
>
> Diffs
> -----
>
> src/slave/gc.cpp 407f6b23f87cf2e2bdaf873c8adcda57f5d559b3
>
>
> Diff: https://reviews.apache.org/r/67822/diff/1/
>
>
> Testing
> -------
>
> ```make```
>
>
> Thanks,
>
> Zhitao Li
>
>
|