mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Review Request 67820: Fixed XfsDiskIsolatorProcess::recover() signature.
Date Tue, 03 Jul 2018 21:31:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and James Peach.


Repository: mesos


Description
-------

Change r/67312 replaced std::list with std::vector in several places
including the Isolator interface. However XfsDiskIsolatorProcess was not
updated and because of that its recover() method became "disabled".


Diffs
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9



Diff: https://reviews.apache.org/r/67820/diff/1/


Testing
-------

Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery`
test, that was broken because of the issue, passed.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message