mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67817: Improved logging for offers and inverse offers.
Date Tue, 03 Jul 2018 20:56:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/
-----------------------------------------------------------

(Updated July 3, 2018, 1:56 p.m.)


Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.


Changes
-------

Addressed feedback.


Repository: mesos


Description
-------

Log offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.

Also log at `VLOG(2)` level which resources are offered.

NOTE: It is possible to enable `VLOG(2)` logs just for `master.cpp` by
setting the following env variable when starting the master:
`GLOG_vmodule=master=2`.


Diffs (updated)
-----

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 


Diff: https://reviews.apache.org/r/67817/diff/2/

Changes: https://reviews.apache.org/r/67817/diff/1-2/


Testing
-------

Manual testing =).


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message