mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 67722: Fixed unproperly guarded future.
Date Tue, 03 Jul 2018 09:28:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/#review205662
-----------------------------------------------------------




src/master/master.cpp
Lines 9667-9672 (patched)
<https://reviews.apache.org/r/67722/#comment288549>

    Honestly, I'm not even sure there should be a warning there unless there is an error now
that I think about it.
    
    If a framework is refused authentication because of invalid credentials, that is just
normal behavior and should be logged as info.


- Alexander Rojas


On June 25, 2018, 7:56 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67722/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 7:56 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes a bug where the code path could cause a crash because
> of calling `Fture<T>::get()` on a future which is failed.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a 
> 
> 
> Diff: https://reviews.apache.org/r/67722/diff/1/
> 
> 
> Testing
> -------
> 
> ```sh
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message