mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67798: Added "old" cli to the cmake build.
Date Mon, 02 Jul 2018 07:29:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67798/#review205620
-----------------------------------------------------------


Ship it!




Ship It!

- Armand Grillet


On July 2, 2018, 6:03 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67798/
> -----------------------------------------------------------
> 
> (Updated July 2, 2018, 6:03 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds the "old" cli to the cmake build. We generate a binary
> `mesos` unless the new cli is built; in that case we create a binary
> `mesos-old`.
> 
> 
> Diffs
> -----
> 
>   src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427 
> 
> 
> Diff: https://reviews.apache.org/r/67798/diff/1/
> 
> 
> Testing
> -------
> 
> * `cmake -GNinja .. && ninja && ./src/mesos`
> * `cmake -GNinja -DENABLE_NEW_CLI=ON .. && ninja && ./src/mesos; ./src/mesos-old`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message