mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67795: Moved `CheckInfo` validation to common code.
Date Mon, 02 Jul 2018 01:17:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67795/#review205616
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67794, 67795]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 1, 2018, 10:09 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67795/
> -----------------------------------------------------------
> 
> (Updated July 1, 2018, 10:09 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9043
>     https://issues.apache.org/jira/browse/MESOS-9043
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master validation uses `validation::checkStatus` and
> `validation::checkStatusInfo`, so move them to the common
> validation library so that the master doesn't have a
> dependency on the checker library.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp 07507a5265613255e778a869094b68a228237f21 
>   src/checks/checker.cpp 6d01349f5a6b7df90c20c2014ad850f312e98593 
>   src/common/validation.hpp 3f60d7ac084b5341e4f33737bff931e3c3daf404 
>   src/common/validation.cpp 74450df1ff0eb2a892f082c60416307ecfcd9e34 
>   src/master/validation.cpp 798fc7975cf0f0b8b029a33137faa1737d47df66 
>   src/slave/validation.cpp 7b4c15a13402665c566236b86326ea324c2e4349 
>   src/tests/check_tests.cpp 73ea5a9e26e58f33d24a1594bbdab7ccceb0ce0f 
> 
> 
> Diff: https://reviews.apache.org/r/67795/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message