From reviews-return-79251-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jun 25 22:55:41 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 78FE61890A for ; Mon, 25 Jun 2018 22:55:41 +0000 (UTC) Received: (qmail 36898 invoked by uid 500); 25 Jun 2018 22:55:41 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36858 invoked by uid 500); 25 Jun 2018 22:55:41 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36847 invoked by uid 99); 25 Jun 2018 22:55:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2018 22:55:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4CE9CCDBFC; Mon, 25 Jun 2018 22:55:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.4 X-Spam-Level: * X-Spam-Status: No, score=1.4 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BYGiflZE0NgQ; Mon, 25 Jun 2018 22:55:39 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C79265F3CE; Mon, 25 Jun 2018 22:55:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 634D1E00B8; Mon, 25 Jun 2018 22:55:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1DC80C400F6; Mon, 25 Jun 2018 22:55:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7201711199137707325==" MIME-Version: 1.0 Subject: Re: Review Request 67388: Moved libprocess POSIX and Windows implementations to separate folders. From: Joseph Wu To: Benjamin Mahler , Eric Mumau , Radhika Jandhyala , Joseph Wu , Andrew Schwartzmeyer , John Kordich Cc: Akash Gupta , mesos Date: Mon, 25 Jun 2018 22:55:37 -0000 Message-ID: <20180625225537.19790.59348@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67388/ X-Sender: Joseph Wu X-ReviewBoard-ShipIt: 1 References: <20180621114800.56607.20220@reviews-vm2.apache.org> In-Reply-To: <20180621114800.56607.20220@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libev.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libev/libev.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/subprocess_windows.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/poll_socket.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libevent/libevent_poll.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/io_internal.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libev.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libevent.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/subprocess.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libevent_poll.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libevent/libevent.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/subprocess_posix.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libev_poll.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/subprocess_posix.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/io.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libevent.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/poll_socket.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/subprocess.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libevent_ssl_socket.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/windows/subprocess.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libev/libev.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/subprocess_windows.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/windows/subprocess.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libev/libev_poll.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/libevent_ssl_socket.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/posix/libevent/libevent.cpp Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============7201711199137707325== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67388/#review205316 ----------------------------------------------------------- Ship it! 3rdparty/libprocess/src/io.cpp Lines 136-147 (original), 41-50 (patched) Technically, you could remove these and then move the implementation in `src/posix/io.cpp` out of the `internal` namespace. I'm fine with the diff as-is though. - Joseph Wu On June 21, 2018, 4:47 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67388/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 4:47 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8668 > > > Repository: mesos > > > Description > ------- > > In preparation of the new Windows IOCP library, the POSIX and Windows > specific files in libprocess have been moved to their own directories > for better code organization. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 8910416ce4313a0d70721cf1bb1d1453aaf691f9 > 3rdparty/libprocess/src/CMakeLists.txt 619183eff6d6d301a011ab03f007410f50a0aa4f > 3rdparty/libprocess/src/io.cpp 97f2b17092fbd23528cf3220fee5927a1ec38aba > 3rdparty/libprocess/src/io_internal.hpp PRE-CREATION > 3rdparty/libprocess/src/libev.hpp > 3rdparty/libprocess/src/libev.cpp > 3rdparty/libprocess/src/libev_poll.cpp > 3rdparty/libprocess/src/libevent.hpp > 3rdparty/libprocess/src/libevent.cpp > 3rdparty/libprocess/src/libevent_poll.cpp > 3rdparty/libprocess/src/libevent_ssl_socket.hpp > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 3rdparty/libprocess/src/poll_socket.cpp > 3rdparty/libprocess/src/posix/io.cpp PRE-CREATION > 3rdparty/libprocess/src/socket.cpp 504cb541785650d2d05aabd25f5258b9bad52baa > 3rdparty/libprocess/src/subprocess.cpp 0b2c02a9651563961532fdd5ab0f6d558f69f74e > 3rdparty/libprocess/src/subprocess_posix.hpp > 3rdparty/libprocess/src/subprocess_posix.cpp > 3rdparty/libprocess/src/subprocess_windows.hpp > 3rdparty/libprocess/src/subprocess_windows.cpp > > > Diff: https://reviews.apache.org/r/67388/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > > --===============7201711199137707325==--