From reviews-return-78930-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jun 15 15:20:15 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 86A0518F3D for ; Fri, 15 Jun 2018 15:20:15 +0000 (UTC) Received: (qmail 38256 invoked by uid 500); 15 Jun 2018 15:20:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 38227 invoked by uid 500); 15 Jun 2018 15:20:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 38210 invoked by uid 99); 15 Jun 2018 15:20:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2018 15:20:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 613A41A0808; Fri, 15 Jun 2018 15:20:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4TKUvXMp6zdK; Fri, 15 Jun 2018 15:20:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 34C835F431; Fri, 15 Jun 2018 15:20:07 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CF21BE0101; Fri, 15 Jun 2018 15:20:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 966B3C40041; Fri, 15 Jun 2018 15:20:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2742939040402377944==" MIME-Version: 1.0 Subject: Re: Review Request 67488: Updated CLI to Python 3. From: Mesos Reviewbot Windows To: Benjamin Bannier , Kevin Klues , Andrew Schwartzmeyer , Eric Chung Cc: Mesos Reviewbot Windows , Armand Grillet , mesos Date: Fri, 15 Jun 2018 15:20:06 -0000 Message-ID: <20180615152006.54202.99903@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67488/ X-Sender: Mesos Reviewbot Windows References: <20180612163000.44565.72201@reviews-vm2.apache.org> In-Reply-To: <20180612163000.44565.72201@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============2742939040402377944== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204850 ----------------------------------------------------------- PASS: Mesos patch 67488 was successfully built and tested. Reviews applied: `['67413', '67487', '67488']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488 - Mesos Reviewbot Windows On June 12, 2018, 4:29 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67488/ > ----------------------------------------------------------- > > (Updated June 12, 2018, 4:29 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues. > > > Bugs: MESOS-8955 > https://issues.apache.org/jira/browse/MESOS-8955 > > > Repository: mesos > > > Description > ------- > > The build tools are also up to date thus the CLI can still be built > using Autotools and CMake. No features have been added to the CLI. > > The PyInstaller dependency has been updated due to issues with > PyInstaller 3.1.1 and Python 3.6. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d > configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 > src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 > src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca > src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 > src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c > src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f > src/python/cli_new/lib/cli/config.py 6f92622725d8a042a2a728fd38c977ac690ef6be > src/python/cli_new/lib/cli/docopt.py 86a4e9c74326fb80cc59487113f07358dd96960d > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/plugins/agent/main.py 59280ece8ebd00bb96df3675b6356a26cc48a2c0 > src/python/cli_new/lib/cli/plugins/base.py e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c > src/python/cli_new/lib/cli/plugins/task/main.py cc6cff56c71262729a8870017bef2e97636abe5a > src/python/cli_new/lib/cli/tests/base.py 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 > src/python/cli_new/lib/cli/tests/tests.py 79e1036f6d11c63884091fe43672607b03955c1a > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > src/python/cli_new/pip-requirements.txt aeb023325e838aa42f8d7418bb7f8293c3fa5614 > src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 > src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 > > > Diff: https://reviews.apache.org/r/67488/diff/4/ > > > Testing > ------- > > Testing done on Fedora 25 with `python` being Python 2.7, `python3` being Python 3.5 and `python36` being Python 3.6. > > > For Autotools: > > ``` > $ ./bootstrap > $ mkdir build > $ cd build > $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java > $ make check > ``` > > For CMake: > > ``` > $ ./bootstrap > $ mkdir build > $ cd build > $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36 > $ cmake --build . -- -j16 > $ ./src/mesos > Mesos CLI > > Usage: > mesos (-h | --help) > mesos --version > mesos [...] > > Options: > -h --help Show this screen. > --version Show version info. > > Commands: > agent Interacts with the Mesos agents > config Interacts with the Mesos CLI configuration file > task Interacts with the tasks running in a Mesos cluster > > See 'mesos help ' for more information on a specific command. > $ cmake --build . --target tests -- -j16 > $ ctest -R CLI > Test project /home/agrillet/apache-mesos/build > Start 4: CLITests > 1/1 Test #4: CLITests ......................... Passed 3.63 sec > > 100% tests passed, 0 tests failed out of 1 > ``` > > Checked that the the CLI tests were run, that the content of the directory build/src/cli was as expected, and that build/src/mesos was correctly running. > > > Thanks, > > Armand Grillet > > --===============2742939040402377944==--