From reviews-return-78929-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jun 15 14:41:22 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 087A818D2E for ; Fri, 15 Jun 2018 14:41:22 +0000 (UTC) Received: (qmail 31301 invoked by uid 500); 15 Jun 2018 14:41:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31270 invoked by uid 500); 15 Jun 2018 14:41:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31256 invoked by uid 99); 15 Jun 2018 14:41:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2018 14:41:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CB40CC0100; Fri, 15 Jun 2018 14:41:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id M8W_kzFPtfgz; Fri, 15 Jun 2018 14:41:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BC3845F1D4; Fri, 15 Jun 2018 14:41:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 21382E0101; Fri, 15 Jun 2018 14:41:18 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0B38CC40041; Fri, 15 Jun 2018 14:41:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2965467421915352525==" MIME-Version: 1.0 Subject: Re: Review Request 67604: Made configured shell script inputs executable. From: Mesos Reviewbot To: Till Toenshoff , Andrew Schwartzmeyer Cc: Benjamin Bannier , Mesos Reviewbot , mesos Date: Fri, 15 Jun 2018 14:41:18 -0000 Message-ID: <20180615144118.54203.19548@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67604/ X-Sender: Mesos Reviewbot References: <20180614222008.49682.49414@reviews-vm2.apache.org> In-Reply-To: <20180614222008.49682.49414@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============2965467421915352525== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67604/#review204847 ----------------------------------------------------------- Patch looks great! Reviews applied: [67603, 67604] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 14, 2018, 10:20 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67604/ > ----------------------------------------------------------- > > (Updated June 14, 2018, 10:20 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > While this is not required for the autotools build where manual > intervention is needed to make the output of `AC_CONFIG_FILES` > executable, cmake will copy existing permissions when executing > `configure_file`. Making the input files explicitly executable > simplifies the needed steps in the cmake build and also serves as > documentation. > > > Diffs > ----- > > cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e > > > Diff: https://reviews.apache.org/r/67604/diff/1/ > > > Testing > ------- > > NOTE: > > **Reviewboard seems to have issues tracking the permission changes in this patch. > Please apply the patch file below instead of the patch related directly to this rr.** > > (done shouting) > > > # Testing done > > * made sure that all shell scripts created as part of `cmake ..` are executable > * `make distcheck` for good measure, but likely unable to detect issues here. > > > File Attachments > ---------------- > > PLEASE APPLY THIS PATCH MANUALLY INSTEAD > https://reviews.apache.org/media/uploaded/files/2018/06/14/2503e381-af7c-4de4-ac67-d259102bf5cf__0001-Made-configured-shell-script-inputs-executable.patch > > > Thanks, > > Benjamin Bannier > > --===============2965467421915352525==--