From reviews-return-78784-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jun 13 13:55:32 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 706A218902 for ; Wed, 13 Jun 2018 13:55:32 +0000 (UTC) Received: (qmail 53626 invoked by uid 500); 13 Jun 2018 13:55:32 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 53592 invoked by uid 500); 13 Jun 2018 13:55:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 53581 invoked by uid 99); 13 Jun 2018 13:55:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2018 13:55:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 55D571A072B; Wed, 13 Jun 2018 13:55:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.15 X-Spam-Level: ** X-Spam-Status: No, score=2.15 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HnqDcW4MXbB4; Wed, 13 Jun 2018 13:55:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A5DBD5F343; Wed, 13 Jun 2018 13:55:26 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E6084E00CC; Wed, 13 Jun 2018 13:55:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8AD51C40045; Wed, 13 Jun 2018 13:55:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8741629724691312352==" MIME-Version: 1.0 Subject: Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set. From: Kevin Klues To: Benjamin Bannier , Kevin Klues , Andrew Schwartzmeyer , Eric Chung Cc: Armand Grillet , mesos Date: Wed, 13 Jun 2018 13:55:25 -0000 Message-ID: <20180613135525.37952.40025@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kevin Klues X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67412/ X-Sender: Kevin Klues References: <20180601151452.24176.72429@reviews-vm2.apache.org> In-Reply-To: <20180601151452.24176.72429@reviews-vm2.apache.org> Reply-To: Kevin Klues X-ReviewRequest-Repository: mesos --===============8741629724691312352== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67412/#review204688 ----------------------------------------------------------- configure.ac Lines 2278 (patched) Instead of this long complicated line, can we just set PYTHON_VERSION directrly from: ``` PYTHON_VERSION=`$PYTHON -c "import sys; sys.stdout.write(sys.version[[:3]])"` ``` - Kevin Klues On June 1, 2018, 3:14 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67412/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 3:14 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues. > > > Bugs: MESOS-8955 > https://issues.apache.org/jira/browse/MESOS-8955 > > > Repository: mesos > > > Description > ------- > > We set `PYTHON` and `PYTHON_VERSION` when configuring the build. > We now cover all possible cases (both variables set, only one, none). > This ensures that both variables are set after being checked. > > > Diffs > ----- > > configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 > > > Diff: https://reviews.apache.org/r/67412/diff/2/ > > > Testing > ------- > > I added two lines after the new code: > ``` > AC_MSG_NOTICE([$PYTHON]) > AC_MSG_NOTICE([$PYTHON_VERSION]) > ``` > > Then, when using `configure`, I've checked the output. > ``` > $ ../configure > ... > configure: /usr/bin/python > configure: 2.7 > $ PYTHON_VERSION=4 ../configure > ... > configure: python4 > configure: 4 > $ PYTHON=yolo ../configure > ... > configure: yolo > configure: > ``` > > > Thanks, > > Armand Grillet > > --===============8741629724691312352==--