From reviews-return-78587-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jun 7 12:41:08 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3AAB184C8 for ; Thu, 7 Jun 2018 12:41:08 +0000 (UTC) Received: (qmail 64294 invoked by uid 500); 7 Jun 2018 12:41:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64261 invoked by uid 500); 7 Jun 2018 12:41:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64244 invoked by uid 99); 7 Jun 2018 12:41:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2018 12:41:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A0368C0090; Thu, 7 Jun 2018 12:41:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.949 X-Spam-Level: X-Spam-Status: No, score=0.949 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pxXMPsqgqlGQ; Thu, 7 Jun 2018 12:41:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BDDAF5F57F; Thu, 7 Jun 2018 12:41:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 63731E00D3; Thu, 7 Jun 2018 12:41:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4C5BFC4010A; Thu, 7 Jun 2018 12:41:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2125192040153886917==" MIME-Version: 1.0 Subject: Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization. From: Benjamin Bannier To: Jie Yu , Gilbert Song Cc: Benjamin Bannier , Andrew Schwartzmeyer , mesos Date: Thu, 07 Jun 2018 12:41:05 -0000 Message-ID: <20180607124105.10881.80818@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67398/ X-Sender: Benjamin Bannier References: <20180604233015.9512.50437@reviews-vm2.apache.org> In-Reply-To: <20180604233015.9512.50437@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============2125192040153886917== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 5, 2018, 1:30 a.m., Jie Yu wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Lines 583-585 (original), 584-586 (patched) > > > > > > I think there's a race here. If the process is spawned, but the initailize is not called yet, the command might return a failure? > > > > I think a better way is to have a helper in the Waiter so that we can wait until the route has been setup. I added an explicitly promise for users to detect whether the process was initialized. > On June 5, 2018, 1:30 a.m., Jie Yu wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Line 1435 (original), 1426-1427 (patched) > > > > > > Hum, I think if the route is not setup, the wget will get a 404? > > > > My suggestion is to make this more explicit. For instance, have a rourte called `/trigger` and a Promise called `triggered` (for client to trigger an event that test is waiting), and have another route called `/wait` and have a Promise called `notify` (for test to notify the client). This is not needed anymore since we use named pipes in this test now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67398/#review204288 ----------------------------------------------------------- On June 7, 2018, 2:40 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67398/ > ----------------------------------------------------------- > > (Updated June 7, 2018, 2:40 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-8917 > https://issues.apache.org/jira/browse/MESOS-8917 > > > Repository: mesos > > > Description > ------- > > Some tests of nested container functionality used pipes passed to > launched tasks to detect whether a task has actually started executing > the workload (`TASK_RUNNING` updates might be sent before the task > workload is actually started). > > Once we avoid leaking unspecified file descriptors into forked > processes, this test setup will be broken. In this patch we replace > the use of pipes for synchronization with HTTP requests to an actor > running in the tests, or wait on other observable side effects. > > > Diffs > ----- > > src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp 6050e6ebed87249382d56aedb6d98d3cf9812bb9 > > > Diff: https://reviews.apache.org/r/67398/diff/3/ > > > Testing > ------- > > `sudo make check` > > Tested in internal CI on a number of platforms. > > > Thanks, > > Benjamin Bannier > > --===============2125192040153886917==--