From reviews-return-78489-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jun 4 19:11:44 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB27318BF9 for ; Mon, 4 Jun 2018 19:11:44 +0000 (UTC) Received: (qmail 22442 invoked by uid 500); 4 Jun 2018 19:11:44 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22406 invoked by uid 500); 4 Jun 2018 19:11:44 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22388 invoked by uid 99); 4 Jun 2018 19:11:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jun 2018 19:11:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 90AD618061F; Mon, 4 Jun 2018 19:11:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.89 X-Spam-Level: X-Spam-Status: No, score=0.89 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id TWp0INX9zwlF; Mon, 4 Jun 2018 19:11:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B38505F1EE; Mon, 4 Jun 2018 19:11:40 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 17E58E0016; Mon, 4 Jun 2018 19:11:40 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 014B4C40234; Mon, 4 Jun 2018 19:11:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3534458111075998105==" MIME-Version: 1.0 Subject: Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests. From: John Kordich via Review Board To: Akash Gupta , Eric Mumau , Radhika Jandhyala , Joseph Wu , Andrew Schwartzmeyer , Chun-Hung Hsiao , Jie Yu , Li Li Cc: Mesos Reviewbot , Mesos Reviewbot Windows , John Kordich , mesos Date: Mon, 04 Jun 2018 19:11:40 -0000 Message-ID: <20180604191140.9511.62044@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Kordich X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67066/ X-Sender: John Kordich References: <20180601215852.24176.797@reviews-vm2.apache.org> In-Reply-To: <20180601215852.24176.797@reviews-vm2.apache.org> Reply-To: John Kordich X-ReviewRequest-Repository: mesos --===============3534458111075998105== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ ----------------------------------------------------------- (Updated June 4, 2018, 7:11 p.m.) Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala. Changes ------- Updating review for new reviewbot pass Bugs: MESOS-8064 https://issues.apache.org/jira/browse/MESOS-8064 Repository: mesos Description ------- Modified the fetcher to use libarchive and added associated tests. Diffs (updated) ----- src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 Diff: https://reviews.apache.org/r/67066/diff/9/ Changes: https://reviews.apache.org/r/67066/diff/8-9/ Testing ------- I've built on Windows with CMake and have run all tests, which all pass. I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass. Thanks, John Kordich --===============3534458111075998105==--