| Gastón Kleiman |
Review Request 67441: Testing windows reviewbot utf8 handling. |
Mon, 04 Jun, 22:34 |
| Gastón Kleiman |
Re: Review Request 67616: Added the limitation of the container id length. |
Mon, 18 Jun, 23:37 |
| Gastón Kleiman |
Re: Review Request 67616: Added the limitation of the container id length. |
Mon, 18 Jun, 23:41 |
| Gastón Kleiman |
Re: Review Request 67616: Added the limitation of the container id length. |
Mon, 18 Jun, 23:45 |
| Gastón Kleiman |
Re: Review Request 67616: Added the limitation of the container id length. |
Mon, 18 Jun, 23:49 |
| Gastón Kleiman |
Re: Review Request 67722: Fixed unproperly guarded future. |
Tue, 26 Jun, 16:05 |
| Gastón Kleiman |
Re: Review Request 67776: Added per Framework Calls to metrics. |
Fri, 29 Jun, 01:01 |
| Gastón Kleiman |
Review Request 67791: Prevented master from asking agents to shutdown on auth failures. |
Fri, 29 Jun, 23:23 |
| Stéphane Cottin via Review Board |
Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator. |
Mon, 25 Jun, 19:55 |
| Stéphane Cottin via Review Board |
Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator. |
Tue, 26 Jun, 06:10 |
| Akash Gupta |
Review Request 67455: Windows: Fixed incorrect return code for `os:kill`. |
Tue, 05 Jun, 20:34 |
| Akash Gupta |
Review Request 67456: Windows: Wrapped docker executor code in job object. |
Tue, 05 Jun, 20:38 |
| Akash Gupta |
Review Request 67457: Windows: Ported docker_containerizer_tests.cpp. |
Tue, 05 Jun, 20:40 |
| Akash Gupta |
Re: Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used. |
Fri, 08 Jun, 20:58 |
| Akash Gupta |
Re: Review Request 67286: White list fds that child processes can inherit in stout. |
Sat, 09 Jun, 01:28 |
| Akash Gupta |
Re: Review Request 67287: White list fds that child processes can inherit in libprocess. |
Sat, 09 Jun, 01:30 |
| Akash Gupta |
Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer. |
Sat, 09 Jun, 01:34 |
| Akash Gupta |
Re: Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too. |
Tue, 19 Jun, 21:44 |
| Akash Gupta |
Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type. |
Thu, 21 Jun, 11:34 |
| Akash Gupta |
Re: Review Request 67388: Moved libprocess POSIX and Windows implementations to separate folders. |
Thu, 21 Jun, 11:48 |
| Akash Gupta |
Review Request 67685: Windows: Added `windows_to_unix_epoch` function. |
Thu, 21 Jun, 11:54 |
| Akash Gupta |
Re: Review Request 67390: Windows: Integrated libwinio with libprocess code. |
Thu, 21 Jun, 11:56 |
| Akash Gupta |
Re: Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend. |
Thu, 21 Jun, 11:58 |
| Akash Gupta |
Re: Review Request 67685: Windows: Added `windows_to_unix_epoch` function. |
Sat, 23 Jun, 00:22 |
| Alexander Rojas |
Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys. |
Mon, 04 Jun, 14:04 |
| Alexander Rojas |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Wed, 06 Jun, 08:20 |
| Alexander Rojas |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Wed, 06 Jun, 08:31 |
| Alexander Rojas |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Wed, 06 Jun, 12:52 |
| Alexander Rojas |
Re: Review Request 67472: Fixed CppLinter in python3/mesos-style.py to use correct linter. |
Wed, 06 Jun, 13:23 |
| Alexander Rojas |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Wed, 06 Jun, 13:34 |
| Alexander Rojas |
Review Request 67476: Added guideline for contributions modifying Makefile.am. |
Wed, 06 Jun, 13:56 |
| Alexander Rojas |
Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys. |
Wed, 06 Jun, 13:58 |
| Alexander Rojas |
Review Request 67722: Fixed unproperly guarded future. |
Mon, 25 Jun, 17:56 |
| Alexander Rojas |
Re: Review Request 67722: Fixed unproperly guarded future. |
Tue, 26 Jun, 08:54 |
| Alexander Rukletsov |
Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release. |
Mon, 04 Jun, 13:40 |
| Alexander Rukletsov |
Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses. |
Tue, 05 Jun, 10:46 |
| Alexander Rukletsov |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Wed, 06 Jun, 11:59 |
| Alexander Rukletsov |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Wed, 06 Jun, 13:02 |
| Alexander Rukletsov |
Re: Review Request 67546: Moved RecordIO documentation into separate file. |
Tue, 12 Jun, 17:38 |
| Alexander Rukletsov |
Re: Review Request 67546: Moved RecordIO documentation into separate file. |
Tue, 12 Jun, 17:38 |
| Alexander Rukletsov |
Re: Review Request 67547: Added check for API endpoints that do not support streaming responses. |
Tue, 12 Jun, 17:42 |
| Alexander Rukletsov |
Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. |
Wed, 13 Jun, 11:31 |
| Alexander Rukletsov |
Re: Review Request 67547: Added check for API endpoints not supporting streaming responses. |
Thu, 14 Jun, 13:33 |
| Alexander Rukletsov |
Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses. |
Thu, 14 Jun, 13:41 |
| Alexander Rukletsov |
Re: Review Request 67525: Removed static variable with non-constant initialization. |
Thu, 14 Jun, 14:13 |
| Alexander Rukletsov |
Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. |
Fri, 15 Jun, 13:36 |
| Alexander Rukletsov |
Re: Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`. |
Fri, 15 Jun, 13:36 |
| Alexander Rukletsov |
Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe. |
Fri, 15 Jun, 13:36 |
| Andrei Budnik |
Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. |
Wed, 13 Jun, 17:26 |
| Andrew Schwartzmeyer |
Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive. |
Mon, 04 Jun, 18:09 |
| Andrew Schwartzmeyer |
Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive. |
Mon, 04 Jun, 18:15 |
| Andrew Schwartzmeyer |
Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization. |
Mon, 04 Jun, 23:13 |
| Andrew Schwartzmeyer |
Re: Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`. |
Tue, 05 Jun, 21:02 |
| Andrew Schwartzmeyer |
Review Request 67464: Fixed `python3/mesos-style.py`. |
Tue, 05 Jun, 23:15 |
| Andrew Schwartzmeyer |
Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used. |
Tue, 05 Jun, 23:16 |
| Andrew Schwartzmeyer |
Re: Review Request 67463: Fixed type error when using `check_output` in Python 3 scripts. |
Thu, 07 Jun, 16:28 |
| Andrew Schwartzmeyer |
Re: Review Request 67455: Windows: Fixed incorrect return code for `os:kill`. |
Thu, 07 Jun, 18:22 |
| Andrew Schwartzmeyer |
Re: Review Request 67456: Windows: Wrapped docker executor code in job object. |
Thu, 07 Jun, 21:21 |
| Andrew Schwartzmeyer |
Re: Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used. |
Thu, 07 Jun, 21:59 |
| Andrew Schwartzmeyer |
Review Request 67496: Ported `EnvTest.EraseEnv` to Windows, with added comments. |
Thu, 07 Jun, 23:19 |
| Andrew Schwartzmeyer |
Re: Review Request 67335: Added `windows/cpu` and `windows/mem` isolators into `agent.md`. |
Fri, 08 Jun, 17:26 |
| Andrew Schwartzmeyer |
Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type. |
Fri, 08 Jun, 17:29 |
| Andrew Schwartzmeyer |
Re: Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess. |
Fri, 08 Jun, 17:38 |
| Andrew Schwartzmeyer |
Re: Review Request 67387: Updated Mesos code to use `io::prepare_async`. |
Fri, 08 Jun, 17:38 |
| Andrew Schwartzmeyer |
Re: Review Request 67388: Moved: `io::internal::read/write` to separate file. |
Fri, 08 Jun, 18:37 |
| Andrew Schwartzmeyer |
Re: Review Request 67389: Windows: Implemented Windows IOCP async backend. |
Fri, 08 Jun, 21:28 |
| Andrew Schwartzmeyer |
Re: Review Request 67390: Windows: Integrated libwinio with libprocess code. |
Fri, 08 Jun, 22:46 |
| Andrew Schwartzmeyer |
Re: Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend. |
Fri, 08 Jun, 22:58 |
| Andrew Schwartzmeyer |
Re: Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend. |
Fri, 08 Jun, 22:59 |
| Andrew Schwartzmeyer |
Re: Review Request 67393: Windows: Ported io_tests.cpp. |
Fri, 08 Jun, 23:06 |
| Andrew Schwartzmeyer |
Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp. |
Fri, 08 Jun, 23:12 |
| Andrew Schwartzmeyer |
Re: Review Request 67287: White list fds that child processes can inherit in libprocess. |
Mon, 11 Jun, 16:40 |
| Andrew Schwartzmeyer |
Re: Review Request 67286: White list fds that child processes can inherit in stout. |
Mon, 11 Jun, 16:45 |
| Andrew Schwartzmeyer |
Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer. |
Mon, 11 Jun, 16:52 |
| Andrew Schwartzmeyer |
Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer. |
Mon, 11 Jun, 17:14 |
| Andrew Schwartzmeyer |
Review Request 67532: Removed superfluous guard around `signals.hpp`. |
Mon, 11 Jun, 20:12 |
| Andrew Schwartzmeyer |
Review Request 67533: Removed superfluous guard around `signals.hpp`. |
Mon, 11 Jun, 20:12 |
| Andrew Schwartzmeyer |
Review Request 67534: CMake: Added libapr as interface dependency of libsvn. |
Mon, 11 Jun, 21:57 |
| Andrew Schwartzmeyer |
Review Request 67535: CMake: Removed explicit linkage of libapr. |
Mon, 11 Jun, 21:57 |
| Andrew Schwartzmeyer |
Re: Review Request 67496: Ported `EnvTest.EraseEnv` to Windows, with added comments. |
Mon, 11 Jun, 22:29 |
| Andrew Schwartzmeyer |
Review Request 67551: Fixed `push-commits.py` for Windows. |
Tue, 12 Jun, 17:41 |
| Andrew Schwartzmeyer |
Re: Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`. |
Tue, 12 Jun, 17:49 |
| Andrew Schwartzmeyer |
Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp. |
Tue, 12 Jun, 18:03 |
| Andrew Schwartzmeyer |
Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp. |
Tue, 12 Jun, 18:03 |
| Andrew Schwartzmeyer |
Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`. |
Tue, 12 Jun, 21:09 |
| Andrew Schwartzmeyer |
Review Request 67580: Fixed use of rbt command in `push-commits.py` for Windows. |
Wed, 13 Jun, 17:31 |
| Andrew Schwartzmeyer |
Re: Review Request 67287: White list fds that child processes can inherit in libprocess. |
Wed, 13 Jun, 18:09 |
| Andrew Schwartzmeyer |
Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer. |
Wed, 13 Jun, 18:11 |
| Andrew Schwartzmeyer |
Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer. |
Wed, 13 Jun, 18:11 |
| Andrew Schwartzmeyer |
Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too. |
Wed, 13 Jun, 22:30 |
| Andrew Schwartzmeyer |
Review Request 67600: Fixed break of `port_mapping_tests.cpp`. |
Thu, 14 Jun, 17:38 |
| Andrew Schwartzmeyer |
Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`. |
Thu, 14 Jun, 18:46 |
| Andrew Schwartzmeyer |
Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`. |
Thu, 14 Jun, 18:46 |
| Andrew Schwartzmeyer |
Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`. |
Thu, 14 Jun, 20:22 |
| Andrew Schwartzmeyer |
Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`. |
Thu, 14 Jun, 20:27 |
| Andrew Schwartzmeyer |
Review Request 67607: Windows: Fixed libarchive and zlib linkage warnings. |
Thu, 14 Jun, 23:20 |
| Andrew Schwartzmeyer |
Re: Review Request 67308: Documented how to setup and use cquery with Mesos. |
Fri, 15 Jun, 20:45 |
| Andrew Schwartzmeyer |
Re: Review Request 67604: Made configured shell script inputs executable. |
Fri, 15 Jun, 23:02 |
| Andrew Schwartzmeyer |
Re: Review Request 67606: Allow for unbundled libevent cmake builds. |
Fri, 15 Jun, 23:19 |
| Andrew Schwartzmeyer |
Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers. |
Mon, 18 Jun, 20:23 |