mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Chung <cinchu...@gmail.com>
Subject Re: Review Request 67185: Added request_protobuf to mesos.http.
Date Thu, 28 Jun 2018 06:17:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67185/
-----------------------------------------------------------

(Updated June 28, 2018, 6:17 a.m.)


Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao Li.


Repository: mesos


Description (updated)
-------

This change adds the method `Resource.request_protobuf()` which assumes
that both the request and response data are encoded in protobuf. This
will be used later in the RPC client, which will also include a decoding
step.

Testing Done:
Ran unit tests with `tox` under `src/python/lib`


Diffs (updated)
-----

  src/python/lib/mesos/constants.py PRE-CREATION 
  src/python/lib/mesos/http.py 073c159dc6916fa5d7349a033db022d7175aef05 
  src/python/lib/requirements.in 0742f3d846c99c1c4907d9628fb49845564563b2 
  src/python/lib/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b 


Diff: https://reviews.apache.org/r/67185/diff/4/

Changes: https://reviews.apache.org/r/67185/diff/3-4/


Testing
-------


Thanks,

Eric Chung


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message