mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 67390: Windows: Integrated libwinio with libprocess code.
Date Thu, 21 Jun 2018 11:56:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67390/
-----------------------------------------------------------

(Updated June 21, 2018, 11:56 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Changes
-------

file rename and feedback.


Bugs: MESOS-8668, MESOS-8671 and MESOS-8672
    https://issues.apache.org/jira/browse/MESOS-8668
    https://issues.apache.org/jira/browse/MESOS-8671
    https://issues.apache.org/jira/browse/MESOS-8672


Repository: mesos


Description
-------

The libprocess eventloops are used to implement the `EventLoop`,
SocketImpl` and `io::read/write` interfaces. Thus, by providing those
implementations using libwinio, libprocess now supports the libwinio
backend.


Diffs (updated)
-----

  3rdparty/libprocess/src/windows/event_loop.hpp PRE-CREATION 
  3rdparty/libprocess/src/windows/event_loop.cpp PRE-CREATION 
  3rdparty/libprocess/src/windows/io.cpp PRE-CREATION 
  3rdparty/libprocess/src/windows/poll_socket.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67390/diff/2/

Changes: https://reviews.apache.org/r/67390/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message