mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.
Date Fri, 15 Jun 2018 22:34:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67596/#review204883
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On June 14, 2018, 3:47 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67596/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 3:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6622
>     https://issues.apache.org/jira/browse/MESOS-6622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test is flaky because it tries to download the 1GB 'nvidia/cuda'
> image from Docker Hub, which might take more than 1 minute and cause
> the command executor unable to register in time.
> 
> This patch fixes this problem by using the default executor, which does
> not wait for fetching task images before registration. If the image
> fetch stalls (i.e. makes no progress) more than 1 minute, the container
> will fail because of the `--fetcher_stall_timeout` agent flag.
> 
> The time we wait for `TASK_FINISHED` is also extended to 180 seconds.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp d8c3e6d08a70bd129d8ac9c336be7a2bf7a4b0b2

> 
> 
> Diff: https://reviews.apache.org/r/67596/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message