mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.
Date Fri, 15 Jun 2018 13:42:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67412/#review204842
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


configure.ac
Lines 2276-2277 (patched)
<https://reviews.apache.org/r/67412/#comment287583>

    Changing this to the followign before I commit it:
    ```
    +    AC_CHECK_PROG([PYTHON_CHECK], [$PYTHON], [yes])
    +    AS_IF([test "x$PYTHON_CHECK" = "xyes"], [
    +      PYTHON_VERSION=`$PYTHON -c "import sys; sys.stdout.write(sys.version[[:3]])"`
    +    ], [
    +      AC_MSG_ERROR([Cannot find Python executable '$PYTHON' in path.])
    +    ])
    ```


- Kevin Klues


On June 1, 2018, 3:14 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67412/
> -----------------------------------------------------------
> 
> (Updated June 1, 2018, 3:14 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin
Klues.
> 
> 
> Bugs: MESOS-8955
>     https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We set `PYTHON` and `PYTHON_VERSION` when configuring the build.
> We now cover all possible cases (both variables set, only one, none).
> This ensures that both variables are set after being checked.
> 
> 
> Diffs
> -----
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
> 
> 
> Diff: https://reviews.apache.org/r/67412/diff/3/
> 
> 
> Testing
> -------
> 
> I added two lines after the new code:
> ```
>   AC_MSG_NOTICE([$PYTHON])
>   AC_MSG_NOTICE([$PYTHON_VERSION])
> ```
> 
> Then, when using `configure`, I've checked the output.
> ```
> $ ../configure 
> ...
> configure: /usr/bin/python
> configure: 2.7
> $ PYTHON_VERSION=4 ../configure
> ...
> configure: python4
> configure: 4
> $ PYTHON=yolo ../configure
> ...
> configure: yolo
> configure:
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message