mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.
Date Wed, 13 Jun 2018 14:11:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/#review204690
-----------------------------------------------------------




src/Makefile.am
Lines 1804-1816 (original), 1804-1816 (patched)
<https://reviews.apache.org/r/67487/#comment287302>

    Can you set PYTHON here so we know which python version we are building the virtualenv
with?


- Kevin Klues


On June 12, 2018, 2:51 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67487/
> -----------------------------------------------------------
> 
> (Updated June 12, 2018, 2:51 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
>     https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This ensures that we use Python 2 even if the Python
> intepreter under the command `python` is Python 3.
> 
> 
> Diffs
> -----
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
> 
> 
> Diff: https://reviews.apache.org/r/67487/diff/3/
> 
> 
> Testing
> -------
> 
> In `build`:
> ```
> $ ../configure --disable-java --enable-new-cli
> $ GTEST_FILTER="" nice make -j16 check
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message