mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.
Date Tue, 12 Jun 2018 20:38:12 GMT


> On Juni 12, 2018, 9:47 nachm., Jie Yu wrote:
> > src/tests/containerizer/nested_mesos_containerizer_tests.cpp
> > Lines 1017-1028 (original), 1012-1028 (patched)
> > <https://reviews.apache.org/r/67398/diff/3/?file=2036280#file2036280line1052>
> >
> >     Any reason we cannot use a named pipe as well here?

The container mounts its own filesystem. I am not sure how we'd make a named pipe in the host
filesystem visible (we need to be able to access the pipe from thr outside to make sure we
only inspect the filesystem in the nested container once the parent filesystem is ready).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67398/#review204629
-----------------------------------------------------------


On Juni 7, 2018, 2:40 nachm., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67398/
> -----------------------------------------------------------
> 
> (Updated Juni 7, 2018, 2:40 nachm.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-8917
>     https://issues.apache.org/jira/browse/MESOS-8917
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some tests of nested container functionality used pipes passed to
> launched tasks to detect whether a task has actually started executing
> the workload (`TASK_RUNNING` updates might be sent before the task
> workload is actually started).
> 
> Once we avoid leaking unspecified file descriptors into forked
> processes, this test setup will be broken. In this patch we replace
> the use of pipes for synchronization with HTTP requests to an actor
> running in the tests, or wait on other observable side effects.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 6050e6ebed87249382d56aedb6d98d3cf9812bb9

> 
> 
> Diff: https://reviews.apache.org/r/67398/diff/3/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Tested in internal CI on a number of platforms.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message