mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 67423: Skipped metric for non existing paths in gc.
Date Tue, 12 Jun 2018 20:23:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67423/
-----------------------------------------------------------

(Updated June 12, 2018, 1:23 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.


Repository: mesos


Description
-------

Previously, agent gc would increment the "failed" counter if the path
does not exist, but this should not be an issue. This patch skipped such
paths in both "failed" and "succeeded" counters.


Diffs (updated)
-----

  src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 


Diff: https://reviews.apache.org/r/67423/diff/3/

Changes: https://reviews.apache.org/r/67423/diff/2-3/


Testing
-------


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message