mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.
Date Tue, 12 Jun 2018 19:11:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/#review204627
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/gc_tests.cpp
Lines 912 (patched)
<https://reviews.apache.org/r/67421/#comment287212>

    Can you use `DEFAULT_TEST_ROLE` here?
    
    ```
    flags.resources = strings::format(
        "disk(%s):1024",
        DEFAULT_TEST_ROLE).get();
    ```


- Jie Yu


On June 6, 2018, 12:08 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67421/
> -----------------------------------------------------------
> 
> (Updated June 6, 2018, 12:08 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8830
>     https://issues.apache.org/jira/browse/MESOS-8830
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current `ROOT_BusyMountPoint` test would fail because we added
> support for unmounting dangling mount points in directory to gc. This
> patch rewrote this test to reflect that after unmounting, the gc
> succeeded, directory was gone and metrics were correctly reported.
> 
> 
> Diffs
> -----
> 
>   src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 
> 
> 
> Diff: https://reviews.apache.org/r/67421/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message